Skip to content

fix(vue): overlays function properly when used via controller or template - #22155

Merged
liamdebeasi merged 10 commits into
ionic-vuefrom
vue-overlays
Sep 24, 2020
Merged

fix(vue): overlays function properly when used via controller or template#22155
liamdebeasi merged 10 commits into
ionic-vuefrom
vue-overlays

Conversation

@liamdebeasi

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22090

What is the new behavior?

  • Added bindings to allow overlay components to be used in-template
  • Added framework delegate for modal and popover controllers

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi
liamdebeasi merged commit fe5fadf into ionic-vue Sep 24, 2020
@liamdebeasi
liamdebeasi deleted the vue-overlays branch September 24, 2020 15:18
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant