Skip to content

docs(reorder-group): add type to the event param - #22157

Merged
brandyscarney merged 1 commit into
ionic-team:masterfrom
nelson6e65:patch-1
Sep 23, 2020
Merged

docs(reorder-group): add type to the event param#22157
brandyscarney merged 1 commit into
ionic-team:masterfrom
nelson6e65:patch-1

Conversation

@nelson6e65

@nelson6e65 nelson6e65 commented Sep 23, 2020

Copy link
Copy Markdown
Contributor

Improve Angular example by adding missing (any) typehint of the event

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot Bot added the package: core @ionic/core package label Sep 23, 2020
@nelson6e65
nelson6e65 marked this pull request as draft September 23, 2020 20:02
Improve Angular example by adding missing (`any`) typehint of the event
@nelson6e65
nelson6e65 marked this pull request as ready for review September 23, 2020 20:12
@brandyscarney
brandyscarney merged commit ca33886 into ionic-team:master Sep 23, 2020
@brandyscarney

Copy link
Copy Markdown
Member

Thanks so much for the PR! 😊

@nelson6e65
nelson6e65 deleted the patch-1 branch September 23, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants