chore(toggle): remove background vars for now - #26318
Merged
Merged
Conversation
This reverts commit 47e4643.
liamdebeasi
marked this pull request as ready for review
November 18, 2022 17:57
averyrousseau
approved these changes
Nov 18, 2022
liamdebeasi
force-pushed
the
2597-label
branch
from
November 21, 2022 17:43
80eecb9 to
12592b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
As discussed with the team, the toggle does not have any active/hover/focused states right now in Ionic v6. We would like to add these states, but we would like to set aside time to research how best to implement them. As a result, these are being removed from the scope of standalone form components for now.
What is the new behavior?
--background-*and--ripple-colorvariables fromion-toggle.Note: This is not a breaking change. These variables were added in e0e1176 but were never shipped to production.
Does this introduce a breaking change?
Other information