Skip to content

fix(hide-caret): blur listener correctly removed - #26808

Merged
liamdebeasi merged 4 commits into
ionic-team:mainfrom
joewoodhouse:patch-4
Feb 16, 2023
Merged

fix(hide-caret): blur listener correctly removed#26808
liamdebeasi merged 4 commits into
ionic-team:mainfrom
joewoodhouse:patch-4

Conversation

@joewoodhouse

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The enableHideCaretOnScroll shim does not properly remove the event listeners it adds to the input element. Because the listener is a closure containing references to the input and container (ion-content) element, this means those elements can never be free by the GC

Issue URL: #26807

What is the new behavior?

The shim now properly removes the event listener

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: core @ionic/core package label Feb 16, 2023
Comment thread core/src/utils/input-shims/hacks/hide-caret.ts Outdated
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

@liamdebeasi liamdebeasi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@liamdebeasi liamdebeasi changed the title fix(input-shims): Fix not removing the onBlur event properly fix(hide-caret): blur listener correctly removed Feb 16, 2023
@liamdebeasi
liamdebeasi merged commit fef634f into ionic-team:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants