Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
Accelerator
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
ionic-team
/
ionic-framework
Public
Notifications
You must be signed in to change notification settings
Fork
13.3k
Star
52.6k
Code
Issues
587
Pull requests
29
Discussions
Actions
Projects
Wiki
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security and quality
Insights
fix(react/vue): properly switch ionicon based on the mode when ios/md is set
- #26924
#26924
Merged
brandyscarney
merged 15 commits into
main
ionic-team/ionic-framework:main
from
FW-2730
ionic-team/ionic-framework:FW-2730
Copy head branch name to clipboard
Mar 14, 2023
Conversation
Commits
15
(15)
Checks
Files changed
Merged
fix(react/vue): properly switch ionicon based on the mode when ios/md is set
#26924
brandyscarney
merged 15 commits into
main
ionic-team/ionic-framework:main
from
FW-2730
ionic-team/ionic-framework:FW-2730
Copy head branch name to clipboard
Commits
Commits on Mar 7, 2023
fix(vue): properly set icons with ios/md prop based on the config
brandyscarney
committed
989a9d3
View commit details
Copy full SHA for 989a9d3
Browse repository at this point
test(vue): remove identical examples and add more
brandyscarney
committed
8f20147
View commit details
Copy full SHA for 8f20147
Browse repository at this point
test(icon): add ios and md examples with mode set
brandyscarney
committed
4169e6c
View commit details
Copy full SHA for 4169e6c
Browse repository at this point
fix(react): show proper icon based on mode when ios/md prop is set
brandyscarney
committed
326c2ed
View commit details
Copy full SHA for 326c2ed
Browse repository at this point
test(react): add icons page to react test-app
brandyscarney
committed
31d2fcd
View commit details
Copy full SHA for 31d2fcd
Browse repository at this point
Merge branch 'main' into FW-2730
brandyscarney
authored
26f781c
View commit details
Copy full SHA for 26f781c
Browse repository at this point
test(react): add readme for test app instructions
brandyscarney
committed
6bff100
View commit details
Copy full SHA for 6bff100
Browse repository at this point
Merge branch 'main' into FW-2730
brandyscarney
authored
176ead3
View commit details
Copy full SHA for 176ead3
Browse repository at this point
style(vue): lint
brandyscarney
committed
f138c9b
View commit details
Copy full SHA for f138c9b
Browse repository at this point
Commits on Mar 8, 2023
Merge branch 'main' into FW-2730
brandyscarney
authored
b366ac9
View commit details
Copy full SHA for b366ac9
Browse repository at this point
Commits on Mar 13, 2023
fix(vue): account for config being null
brandyscarney
committed
92654f0
View commit details
Copy full SHA for 92654f0
Browse repository at this point
Commits on Mar 14, 2023
test(vue): add cypress test for properly switching ios/md in vue
brandyscarney
committed
7b1d391
View commit details
Copy full SHA for 7b1d391
Browse repository at this point
Merge branch 'main' into FW-2730
brandyscarney
authored
8631bdd
View commit details
Copy full SHA for 8631bdd
Browse repository at this point
test(react): add cypress test for properly switching ios/md in react
brandyscarney
committed
85a646d
View commit details
Copy full SHA for 85a646d
Browse repository at this point
Merge branch 'main' into FW-2730
brandyscarney
committed
057ce2d
View commit details
Copy full SHA for 057ce2d
Browse repository at this point
You can’t perform that action at this time.