Skip to content

fix(item-divider): add margin to end slots #27024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thetaPC wants to merge 8 commits into from
Closed

fix(item-divider): add margin to end slots #27024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0645505
bug(item-divider): add margin to end slots
thetaPC Mar 24, 2023
03e2542
Merge branch 'main' of github.com:ionic-team/ionic-framework into FW-…
thetaPC Mar 24, 2023
f193220
Merge branch 'main' of github.com:ionic-team/ionic-framework into FW-…
thetaPC Mar 27, 2023
8271768
test(item-divider): margin follows button when slotted
thetaPC Mar 27, 2023
02bf9c8
refactor(item-divider): use slot end start margin for button
thetaPC Mar 27, 2023
d971f11
fix(item-divider): simplified property-horizontal mixin
thetaPC Mar 28, 2023
7238af2
Merge branch 'main' of github.com:ionic-team/ionic-framework into FW-…
thetaPC Mar 28, 2023
4bebb78
Merge branch 'main' into FW-3677
liamdebeasi Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/components/item-divider/test/spec/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<ion-item-group>
<ion-item-divider>
<ion-label>A</ion-label>
<ion-button slot="end">My Button</ion-button>
</ion-item-divider>

<ion-item>
Expand Down
25 changes: 4 additions & 21 deletions core/src/themes/ionic.mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,28 +240,11 @@
@if $start == 0 and $end == 0 {
#{$prop}-left: $start;
#{$prop}-right: $end;

} @else {
#{$prop}-left: $start;
#{$prop}-right: $end;

@at-root {
@supports ((margin-inline-start: 0) or (-webkit-margin-start: 0)) {
& {
@if $start != null {
#{$prop}-left: unset;
}
@if $end != null {
#{$prop}-right: unset;
}

-webkit-#{$prop}-start: $start;
#{$prop}-inline-start: $start;
-webkit-#{$prop}-end: $end;
#{$prop}-inline-end: $end;
}
}
}
-webkit-#{$prop}-start: $start;
#{$prop}-inline-start: $start;
-webkit-#{$prop}-end: $end;
#{$prop}-inline-end: $end;
}
}

Expand Down