Skip to content

fix(menu): refs are not destroyed on unmount #27158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamdebeasi merged 1 commit into from
Apr 10, 2023
Merged

fix(menu): refs are not destroyed on unmount #27158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions core/src/components/menu/menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,16 @@ export class Menu implements ComponentInterface, MenuI {
this.updateState();
}

disconnectedCallback() {
async disconnectedCallback() {
/**
* The menu should be closed when it is
* unmounted from the DOM.
* This is an async call, so we need to wait for
* this to finish otherwise contentEl
* will not have MENU_CONTENT_OPEN removed.
*/
await this.close(false);

this.blocker.destroy();
menuController._unregister(this);
if (this.animation) {
Expand All @@ -246,7 +255,7 @@ export class Menu implements ComponentInterface, MenuI {
}

this.animation = undefined;
this.contentEl = this.backdropEl = this.menuInnerEl = undefined;
this.contentEl = undefined;
}

@Listen('ionSplitPaneVisible', { target: 'body' })
Expand Down