feat(back-button): support dynamic type - #27750
Merged
Merged
Conversation
|
|
liamdebeasi
requested review from
a team,
brandyscarney and
thetaPC
and removed request for
a team
July 5, 2023 19:35
liamdebeasi
marked this pull request as ready for review
July 5, 2023 19:35
2 tasks
brandyscarney
approved these changes
Jul 7, 2023
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Great work! I re-ran the failing screenshot job, seems like a flaky test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Back button does not support Dynamic Type.
What is the new behavior?
remand added max+min fonts.rem.min-heightandaspect-ratioso that the circular form factor is preserved as text scales up in the button.Does this introduce a breaking change?
Other information
Demo Video: https://github.com/ionic-team/ionic-framework/assets/2721089/41f1366f-8467-4c19-be75-3f1581e2ff59
Note: The spacing between rows increases significantly due to that test file's use of
<p>elements.The back button also needed a min font size, so I updated the design doc: https://github.com/ionic-team/ionic-framework-design-documents/pull/116