test(many): add font scaling tests - #27836
Merged
Merged
Conversation
|
|
liamdebeasi
marked this pull request as ready for review
July 20, 2023 18:27
liamdebeasi
requested review from
a team and
sean-perkins
and removed request for
a team
July 20, 2023 18:27
sean-perkins
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
While working on Dynamic Type support for searchbar, I discovered that some of the details such as icons/padding can get complex. Previously the team discussed having a linter to ensure that we do not accidentally use px values for font sizes, but I think screenshot tests are warranted particularly for components that have a lot of changes.
What is the new behavior?
Does this introduce a breaking change?
Other information