Conversation
|
|
thetaPC
marked this pull request as ready for review
July 24, 2023 17:22
thetaPC
requested review from
a team and
liamdebeasi
and removed request for
a team
July 24, 2023 17:22
liamdebeasi
suggested changes
Jul 25, 2023
liamdebeasi
left a comment
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Can we add a screenshot test of card, card subtitle, card title, card content all being used with the text scaled up? Here's an example you can follow: https://github.com/ionic-team/ionic-framework/pull/27848/files#diff-2796ab1a929613b79f68ba352b11a68994e442070db3a7bbdbd7a1c0ded56c47R9-R26
(Note: previously the team discussed using a linter to ensure rem usage, but as I got more into development I realized some of these components are a bit more in-depth than I initially thought, so to be safe we're going to add a screenshot test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The card component does not support dynamic type.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build: 7.0.15-dev.11690215123.18be9175
Make sure to enable dynamic type by adding the following to your app:
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-07-24.at.10.19.59.mp4