Skip to content

chore: add infrastructure for standalone - #27866

Merged
liamdebeasi merged 2 commits into
FW-4612from
4612-infra
Jul 27, 2023
Merged

chore: add infrastructure for standalone#27866
liamdebeasi merged 2 commits into
FW-4612from
4612-infra

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Issue number: N/A


What is the current behavior?

We do not have a way of separating lazy loaded components from standalone components. This is important because developers who wish to use Ionic UI components as standalone components do not want their component implementation to use the lazy loaded component.

What is the new behavior?

This PR creates two submodules within @ionic/angular:

@ionic/angular/common located at packages/angular/common:

  • This is where logic that is shared between lazy loaded and standalone components live. For example, if you want to have a lazy loaded IonPopover and standalone IonPopover, you could put the base component implementation here and then have the lazy loaded/standalone implementations extend from this base implementation.

@ionic/angular/standalone located at packages/angular/standalone:

  • This is where the standalone component implementations live. It was added as a separate entry point to avoid any lazy loaded logic from accidentally being pulled in to the final build.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added the package: angular @ionic/angular package label Jul 26, 2023
@liamdebeasi
liamdebeasi marked this pull request as ready for review July 26, 2023 16:55
@liamdebeasi
liamdebeasi merged commit 4553425 into FW-4612 Jul 27, 2023
@liamdebeasi
liamdebeasi deleted the 4612-infra branch July 27, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants