fix(input, textarea): input does not block floating label - #27870
Conversation
liamdebeasi
changed the title
|
The textarea screenshot that changed looks to be due to a browser quirk in Firefox:
Changing the z-index resulted in a 1px diff at the edge of the input. I think this change is fine given that it appears to be a browser rendering quirk. edit: Zoomed in so it's easier to see:
|
|
|
||
| If you need to add E2E tests that are only run on a specific version of the JS Framework, replicate the `VersionTest` component on each partial application. This ensures that tests for framework version X do not get run for framework version Y. | ||
|
|
||
| ### Testing Lazy Loaded Ionic Components |
There was a problem hiding this comment.
This change should be reverted. It probably just got tracked between switching branches.
This reverts commit b4bad45.
mapsandapps
left a comment
mapsandapps
left a comment
There was a problem hiding this comment.
Looks good. I confirmed that the fix works (and I saw the bug submitter confirmed as well), and it looks like everything else works like before. 👍🏻
| }); | ||
| }); | ||
| test.describe(title('input: floating/stacked label layering'), () => { | ||
| test('label should not be covered by text field', async ({ page }) => { |
There was a problem hiding this comment.
Let's add a testInfo.annotations to track the reason behind this test.
| }); | ||
| }); | ||
| test.describe(title('textarea: floating/stacked label layering'), () => { | ||
| test('label should not be covered by text field', async ({ page }) => { |
There was a problem hiding this comment.
Let's add a testInfo.annotations to track the reason behind this test.
5 participants
Issue number: resolves #27812
What is the current behavior?
We currently have CSS to ensure the floating/stacked label is not obscured by the input/textarea when using the outline styles. However, it was discovered that this scenario can happen with any floating/stacked label not just when the input/textarea is using the outline style.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
7.2.1-dev.11690464203.1b2b4419