fix(datetime-button): buttons wrap instead of truncate - #27872
Merged
Conversation
|
|
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
July 27, 2023 18:58
liamdebeasi
requested review from
a team and
averyrousseau
and removed request for
a team
July 28, 2023 17:35
| }); | ||
|
|
||
| test('should truncate text on larger font sizes inside of an item', async ({ page }) => { | ||
| test('should wrap text on larger font sizes inside of an item', async ({ page }) => { |
Member
There was a problem hiding this comment.
Optional: We might be able to remove this test if the behavior doesn't need any special CSS rules to work. I added it because the item specifically needed that min-width: 0 added in order to truncate.
Contributor
Author
There was a problem hiding this comment.
Oh ok good to know! I'll remove it then
brandyscarney
approved these changes
Jul 28, 2023
averyrousseau
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
During the design phase of Dynamic Type, I mistakenly wrote the datetime button requirements based off an outdated version of iOS.
On iOS 15, the text inside of the buttons for the native datetime button get truncated with ellipsis.
On iOS 16, the buttons themselves wrap to the next line and the text does not get truncated.
What is the new behavior?
Does this introduce a breaking change?
Other information
https://github.com/ionic-team/ionic-framework-design-documents/pull/131