Conversation
thetaPC
changed the title
thetaPC
force-pushed
the
FW-4761
branch
2 times, most recently
from
August 3, 2023 23:19
413b814 to
5364723
Compare
thetaPC
marked this pull request as ready for review
August 4, 2023 00:18
sean-perkins
approved these changes
Aug 4, 2023
sean-perkins
left a comment
sean-perkins
left a comment
Contributor
There was a problem hiding this comment.
One non-blocking comment.
| import { AngularDelegate } from '../../providers/angular-delegate'; | ||
| import { ProxyCmp, proxyOutputs } from '../../utils/proxy'; | ||
|
|
||
| const NAV_DELEGATE_INPUTS = ['animated', 'animation', 'root', 'rootParams', 'swipeGesture']; |
Contributor
There was a problem hiding this comment.
~ I would recommend we rename these constants to be NAV_INPUTS and NAV_METHODS. This will align with other component naming conventions that don't include delegate.
The delegate language is strange and not inline with Angular conventions (this is a legacy naming decision, nothing related to your work).
We have to keep the NavDelegate class for now, since renaming it would be a breaking change, but the internal constants we can name to align with other components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Nav does not have Angular standalone component support.
What is the new behavior?
Does this introduce a breaking change?
Other information
N/A