chore: move lazy and standalone tests to subdirectories - #27881
Merged
Conversation
|
|
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
July 28, 2023 15:00
sean-perkins
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
During development I found it difficult to determine where to place standalone vs lazy tests. We currently have a single directory full of all the components. As these tests apps grow (and as we have more standalone test) I think it would help to have separate directories for each.
What is the new behavior?
lazydirectory. This applies to both the cypress tests as well as the Angular components.standalonedirectory. This applies to both the cypress tests as well as the Angular components.standalonedirectory torouting-standaloneso it's clear that this is testing lazy loaded Ionic components and routing with an Angular standalone component.Does this introduce a breaking change?
Other information