feat(angular): add standalone modal - #27885
Merged
Merged
Conversation
|
|
liamdebeasi
commented
Jul 28, 2023
| @@ -0,0 +1,59 @@ | |||
| // TODO: Is there a way we can grab this from angular-component-lib instead? | |||
liamdebeasi
force-pushed
the
FW-4764
branch
2 times, most recently
from
July 31, 2023 13:58
d485de0 to
f4a42b4
Compare
sean-perkins
suggested changes
Aug 4, 2023
sean-perkins
left a comment
sean-perkins
left a comment
Contributor
There was a problem hiding this comment.
Similar feedback to popover. Implementation changes look good. Just one minor documentation tweak.
Co-authored-by: Sean Perkins <sean@ionic.io>
sean-perkins
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Modal cannot be used as a standalone component
What is the new behavior?
Does this introduce a breaking change?
Other information