feat(buttons): support dynamic type - #27896
Merged
Merged
Conversation
|
|
brandyscarney
commented
Jul 31, 2023
brandyscarney
force-pushed
the
FW-4423
branch
2 times, most recently
from
July 31, 2023 19:07
6625dd5 to
b334462
Compare
brandyscarney
requested review from
a team and
averyrousseau
and removed request for
a team
July 31, 2023 19:29
brandyscarney
marked this pull request as ready for review
July 31, 2023 19:29
brandyscarney
marked this pull request as draft
August 1, 2023 17:45
brandyscarney
marked this pull request as ready for review
August 1, 2023 20:40
liamdebeasi
reviewed
Aug 4, 2023
liamdebeasi
left a comment
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
FYI I think you need to sync with FW-4146 since it's showing the button changes that were already merged
Member
Author
|
I synced it with |
sean-perkins
pushed a commit
that referenced
this pull request
Aug 18, 2023
- Adds support for dynamic type by converting `font-size` to use `rem` units. - Updates the button width/height for icon only buttons in `md` to use `rem` units to scale the icon larger - Adds test for scaling the font which checks default buttons, clear buttons (because they use a different `font-size`), buttons with an icon, and a button containing only an icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Toolbar buttons do not support dynamic type.
What is the new behavior?
font-sizeto useremunits.mdto useremunits to scale the icon largerfont-size), buttons with an icon, and a button containing only an iconDoes this introduce a breaking change?
Other information