-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix(alert): radio and checkbox labels wrap to next line #27898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d1c6fe3
80f799d
99341e8
f95dab2
1283b36
f01d216
7a266de
850106a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -152,6 +152,8 @@ | |
|
|
||
| width: 100%; | ||
| height: 100%; | ||
|
|
||
| min-height: inherit; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without this the button inner may have visual diffs since the height is no longer fixed at 48px |
||
| } | ||
|
|
||
|
|
||
|
|
@@ -184,7 +186,7 @@ | |
| text-align: start; | ||
| appearance: none; | ||
|
|
||
| contain: strict; | ||
| contain: content; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without this, each radio/checkbox will still be sized at 48px. This change allows the height of the element to increase as the text wraps. |
||
| } | ||
|
|
||
| .alert-button, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket notes that we should set
height: auto, but I found that created some undesired diffs on radios/checkboxes with short text. I found thatmin-heightgets us to the same desired result without the additional diffs for short text.