refactor: add dynamic type sass functions - #27934
Merged
Merged
Conversation
|
|
This reverts commit ec11c4d.
liamdebeasi
marked this pull request as ready for review
August 4, 2023 20:30
sean-perkins
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
One of the concerns about our dynamic type implementation is that the resulting rem values seem arbitrary. While we currently know this is the result of dividing the px font value by 16, we may not remember this in a few months.
The team would like to evaluate ways to make the font sizes more obvious in terms of how the resulting values are derived.
What is the new behavior?
Open to naming ideas, though I opted to use min/max to describe the clamp operation you are trying to do. For example,
dynamic-font-minmeans you are generating a dynamic font with a minimum font size. This is different than what CSS does where themax()function allows you to set a minimum font size. While this deviates from what CSS does, I think this is a bit easier to understand.Does this introduce a breaking change?
Other information