feat(item-divider): support dynamic type - #27947
Merged
Merged
Conversation
|
|
brandyscarney
commented
Aug 7, 2023
|
|
||
| /// @prop - Font size of the item | ||
| $item-divider-ios-font-size: 17px !default; | ||
| $item-divider-ios-font-size: 1.0625rem !default; |
Member
Author
There was a problem hiding this comment.
The default value this is set at (17px) is actually wrong when compared against native. It should be 15px (or 0.9375rem) at 100%. Something to keep in mind if you are comparing this against native.
Updating the default value is outside the scope of this feature & we have an open ticket to investigate changes for iOS 17 so we could update the font size as part of that.
brandyscarney
marked this pull request as ready for review
August 7, 2023 23:29
brandyscarney
requested review from
a team and
averyrousseau
and removed request for
a team
August 7, 2023 23:29
averyrousseau
approved these changes
Aug 8, 2023
sean-perkins
pushed a commit
that referenced
this pull request
Aug 18, 2023
Adds support for dynamic type by converting `font-size` to use `rem` units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Item dividers do not support dynamic type.
What is the new behavior?
font-sizeto useremunitsDoes this introduce a breaking change?
Other information
Native
I used the Contacts app for comparison
80%100%135%310%Ionic Framework
80%100%135%310%