feat(label): support dynamic type - #27962
Merged
Merged
Conversation
|
|
brandyscarney
force-pushed
the
FW-4433
branch
2 times, most recently
from
August 9, 2023 20:17
1586b11 to
b09affb
Compare
brandyscarney
marked this pull request as ready for review
August 9, 2023 21:04
brandyscarney
requested review from
a team and
mapsandapps
and removed request for
a team
August 9, 2023 21:04
brandyscarney
commented
Aug 14, 2023
2 tasks
mapsandapps
approved these changes
Aug 16, 2023
mapsandapps
left a comment
mapsandapps
left a comment
Contributor
There was a problem hiding this comment.
looks good to me. nice cleanup of unused styles 👍🏻
sean-perkins
pushed a commit
that referenced
this pull request
Aug 18, 2023
Adds support for dynamic type by converting `font-size` to use `rem` units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Labels do not support dynamic type.
What is the new behavior?
font-sizeto useremunitsfont-size: 1remtoion-labelbecause doing this breaks the label font sizes inside of other components such as items, list header, and chip (unless you override it withfont-size: inheritinside of those), when this CSS is not needed for label to dynamically sizeI also made changes to
item-dividerin this PR because it used a shared variable withlabelto change the paragraphfont-size:ion-labelin anion-item-dividerDoes this introduce a breaking change?
Other information