chore(angular): generate standalone component wrappers - #27970
Merged
Conversation
github-actions
Bot
added
package: core
sean-perkins
marked this pull request as ready for review
August 14, 2023 17:48
sean-perkins
requested review from
a team,
brandyscarney and
liamdebeasi
and removed request for
a team
August 14, 2023 17:48
liamdebeasi
reviewed
Aug 15, 2023
sean-perkins
force-pushed
the
sp/angular-standalone-proxies
branch
from
August 17, 2023 16:59
bed7575 to
8e354d1
Compare
Contributor
Author
|
Ok, this is ready for another review. Component wrappers should be generating correctly. I've updated the test app to render the standalone tests within the generated |
liamdebeasi
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Ionic Framework currently only generates the lazy/hydrated Angular component wrappers for the web components.
What is the new behavior?
ion-iconwith the CE build.ion-back-buttonandion-navto be manual component wrappersIonNavto avoid exporting as and simplify navigating the code.Does this introduce a breaking change?
Other information
Related output targets PR: stenciljs/output-targets#367