Skip to content

chore: typescript resolves @ionic/angular/common import paths - #27995

Merged
sean-perkins merged 1 commit into
FW-4612from
sp/angular-workspace-tsconfig
Aug 15, 2023
Merged

chore: typescript resolves @ionic/angular/common import paths#27995
sean-perkins merged 1 commit into
FW-4612from
sp/angular-workspace-tsconfig

Conversation

@sean-perkins

Copy link
Copy Markdown
Contributor

Issue number: N/A


What is the current behavior?

IDEs that perform type checking/include a language service will error on the @ionic/angular/common import paths and not provide intelisense or auto import detection.

CleanShot 2023-08-15 at 09 49 34

What is the new behavior?

  • @ionic/angular/common import paths are detected by IDEs such as VSCode

CleanShot 2023-08-15 at 09 48 40

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added the package: angular @ionic/angular package label Aug 15, 2023
@sean-perkins
sean-perkins marked this pull request as ready for review August 15, 2023 14:35
@sean-perkins
sean-perkins merged commit 104b954 into FW-4612 Aug 15, 2023
@sean-perkins
sean-perkins deleted the sp/angular-workspace-tsconfig branch August 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants