feat(angular): add standalone provideIonicAngular - #27996
Merged
Conversation
|
|
liamdebeasi
changed the title
liamdebeasi
commented
Aug 15, 2023
| export const provideIonicAngular = (config?: IonicConfig): Provider[] => { | ||
| /** | ||
| * TODO FW-XXXX | ||
| * Use makeEnvironmentProviders once Angular 14 support is dropped. |
Contributor
Author
There was a problem hiding this comment.
I tried copy and pasting the implementation of makeEnvironmentProviders. This worked on ng15+ but broke on ng14. I'm not aware of a way to do feature detection here, so I opted to go without it for now.
liamdebeasi
marked this pull request as ready for review
August 15, 2023 16:37
sean-perkins
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Developers using standalone Ionic UI components have no Angular way of bootstrapping Ionic and passing a config. Also, components using
dist-custom-elementswill be hidden because Ionic Core expects ahydratedclass.What is the new behavior?
provideIonicAngularfunction. This is added at the root of an application (typically inmain.ts). This function sets theion-ceclass to show custom element components and initialize Ionic with a developer-specified config.provideIonicAngularcan be set at the application root.Does this introduce a breaking change?
Other information