feat(angular): add standalone providers, route strategy, component binding provider - #27997
Merged
Conversation
|
|
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
August 15, 2023 15:28
sean-perkins
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
While working on the
provideIonicAngularprovider I noticed the following things:IonicRouteStrategyclass for routing.commonmodule since I was just copy and pasting the exact implementation multiple times.What is the new behavior?
IonicRouteStrategyto@ionic/angular/common. Both@ionic/angularand@ionic/angular/standalonere-export this class.AngularDelegatefrom@ionic/angular/standalone. TheAngularDelegatewill be handled in the PR for FW-4766.@ionic/angular/common.@ionic/angularnow imports that logic from@ionic/angular/common. The standalone implementation will be handled in the PR for FW-4766. This change also reduces the amount of APIs we need to export from the common module.Does this introduce a breaking change?
Other information