feat(range): support dynamic type - #28006
Merged
Merged
Conversation
|
|
liamdebeasi
commented
Aug 16, 2023
|
|
||
| :host(.range-has-pin) { | ||
| @include padding($range-md-padding-vertical + $range-md-pin-font-size + $range-md-pin-padding-vertical, null, null, null); | ||
| @include padding($range-md-pin-dimension, null, null, null); |
Contributor
Author
There was a problem hiding this comment.
The existing padding did not account for the new pin size which is why I changed it here
liamdebeasi
commented
Aug 16, 2023
liamdebeasi
marked this pull request as ready for review
August 18, 2023 13:23
liamdebeasi
requested review from
a team and
brandyscarney
and removed request for
a team
August 18, 2023 13:23
brandyscarney
approved these changes
Aug 25, 2023
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks great and the pin scales nicely!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Range does not support dynamic type on iOS
What is the new behavior?
A few notes:
Icon Sizes
The native iOS spec does not have icons scale with the range, so the icons in
ion-rangedo not scale either.Pin Sizing
The proportions of the pin on MD mode will change as text scales. Example
I intentionally did not have the tip of the pin scale since we are scaling according to the text size, and the tip of the pin does not have any text in it. I also thought that having the tip grow significantly would look strange since it would increase the overall size of the component without adding a lot of value.
Text Alignment within Pin
The screenshot diffs here appear to be correct. The text within the pin in
mainis aligned with neither the circle in the pin nor the pin itself. As a result of the changes here, the text is now aligned within the circle (which is the container that has the text).Alignment with Circle
mainAlignment with Pin
mainDoes this introduce a breaking change?
Other information