feat(angular): add enhanced icon support with addIcons - #28009
Merged
Conversation
|
|
liamdebeasi
changed the title
sean-perkins
force-pushed
the
sp/angular-standalone-proxies
branch
from
August 17, 2023 16:59
bed7575 to
8e354d1
Compare
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
August 21, 2023 15:41
sean-perkins
approved these changes
Aug 21, 2023
| import { logoIonic, logoIonitron, logoApple, logoAndroid } from 'ionicons/icons'; | ||
| import { addIcons } from 'ionicons'; | ||
|
|
||
| addIcons({ logoIonic, logoIonitron, logoApple, logoAndroid }); |
Contributor
There was a problem hiding this comment.
Played with this locally, everything looks/works good 👍
It seems to work consistently if you have this outside the class or within the constructor. Does not work (too late in the execution cycle, after connectedCallback fires) if you try to add icons in the ngOnInit lifecycle.
Contributor
Author
There was a problem hiding this comment.
Good catch! We'll want to note this in the docs
Contributor
Author
|
Going to merge, but I'll make sure to review the test app once the new version of Ionicons ships. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Developers have no easy way of passing icon data to the
ion-iconcomponent. The icon component also has no support for switching icons based on mode.What is the new behavior?
Does this introduce a breaking change?
Other information