feat(searchbar): support dynamic type - #28043
Merged
Merged
Conversation
|
|
liamdebeasi
marked this pull request as ready for review
August 25, 2023 12:16
liamdebeasi
requested review from
a team and
thetaPC
and removed request for
a team
August 25, 2023 17:20
liamdebeasi
commented
Aug 28, 2023
|
|
||
| /// @prop - Size of the searchbar input search icon | ||
| $searchbar-md-input-search-icon-size: 20px !default; | ||
| $searchbar-md-input-search-icon-size: dynamic-font(21px) !default; |
Contributor
Author
There was a problem hiding this comment.
This is an intentional change from 20px to 21px.
The actual width/height of the icon was 21px due to the following code:
ionic-framework/core/src/components/searchbar/searchbar.md.scss
Lines 28 to 29 in 01fc9b4
I discussed with Brandy, and these variables were originally used for other things like background size which is why the 1px was not incorporated as part of the sass variable. However, the variable is only used for width/height so I made it part of the variable directly.
averyrousseau
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information