feat(typography): support dynamic type - #28045
Merged
Merged
Conversation
|
|
brandyscarney
commented
Aug 22, 2023
| "prettier": "^2.6.1", | ||
| "rollup": "^2.26.4", | ||
| "sass": "^1.26.10", | ||
| "sass": "^1.33.0", |
Member
Author
There was a problem hiding this comment.
Prior to upgrading sass I was getting this error when building with the dynamic-font function:
I found this Stack Overflow thread which mentions upgrading to 1.33.0 or higher and that fixed the problem so this change is required for the build to work.
brandyscarney
marked this pull request as ready for review
August 22, 2023 21:48
brandyscarney
requested review from
a team and
thetaPC
and removed request for
a team
August 22, 2023 21:48
thetaPC
approved these changes
Aug 24, 2023
thetaPC
left a comment
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just let the team know that they'll need a npm install to avoid the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The styles for native headings do not support dynamic type.
What is the new behavior?
font-sizeto useremunitscore/src/css/test/a11ytextsincecore/src/cssis where the styles exist, but maybe we don't need the additionala11yfolder since we could just keep all related tests in one filesassversion to^1.33.0Does this introduce a breaking change?