feat(textarea): support dynamic type - #28068
Merged
Merged
Conversation
|
|
mapsandapps
marked this pull request as ready for review
August 28, 2023 18:56
mapsandapps
requested review from
averyrousseau,
liamdebeasi and
sean-perkins
as code owners
August 28, 2023 20:31
github-actions
Bot
added
package: angular
github-actions
Bot
removed
package: angular
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
ion-textarea does not support dynamic type
What is the new behavior?
Does this introduce a breaking change?
Other information
Mostly, dynamic type for textarea was already supported. Only the bottom-content had a static size. All other font sizes were all already relative.
Note: Textareas do not currently look correct when they are in an item, because #27989 has not yet merged. Once that PR is merged, the font sizes within textareas will be relative to the item sizes, and both will scale appropriately. If preferred, I can base this PR off branch FW-4432 instead.