feat(toolbar): support dynamic type - #28073
Merged
Merged
Conversation
|
|
liamdebeasi
marked this pull request as ready for review
August 29, 2023 16:47
liamdebeasi
requested review from
a team and
mapsandapps
and removed request for
a team
August 29, 2023 16:47
mapsandapps
approved these changes
Aug 29, 2023
mapsandapps
left a comment
Contributor
There was a problem hiding this comment.
It took me a while to figure out that none of the weird things I'm seeing with toolbars are actually related to the toolbar styles. It looks like this PR has all that's needed for the toolbar itself 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Most of the work to support dynamic type has been handled in individual components such as
ion-title,ion-button, andion-back-button. However, I noticed two issues:ion-back-button. The following code set the height of theion-back-buttonwhen used in a toolbar with a searchbar:ionic-framework/core/src/components/toolbar/toolbar.ios.scss
Lines 51 to 53 in 01fc9b4
However, this code should never apply because
ion-back-buttonshould be slotted inside ofion-buttonsnotion-back-button. Slottingion-back-buttondirectly inside ofion-toolbarcauses the back button and searchbar to appear on different lines.What is the new behavior?
Does this introduce a breaking change?
Other information