Skip to content

feat(angular): add standalone tabs - #28093

Merged
averyrousseau merged 15 commits into
FW-4612from
FW-4763
Sep 1, 2023
Merged

feat(angular): add standalone tabs#28093
averyrousseau merged 15 commits into
FW-4612from
FW-4763

Conversation

@averyrousseau

@averyrousseau averyrousseau commented Aug 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue number: N/A

What is the current behavior?

Tabs cannot be used as a standalone component.

What is the new behavior?

  • Added tabs as a standalone component.
  • Added a quick test. I included the event checking from the lazy test in the HTML as a smoke check, but didn't bring over the Cypress tests for them since I noticed the other standalone tests have been quick, stripped down affairs. I'm assuming I would just be duplicating effort. Let me know if I should bring more tests over from the lazy version, or even get rid of the event logging from the standalone HTML.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: angular @ionic/angular package label Aug 30, 2023
@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented Aug 30, 2023

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@averyrousseau
averyrousseau marked this pull request as ready for review August 31, 2023 18:08
sean-perkins
sean-perkins reviewed Sep 1, 2023
View reviewed changes
Comment thread packages/angular/test/base/e2e/src/standalone/tabs.spec.ts Outdated
sean-perkins
sean-perkins approved these changes Sep 1, 2023
View reviewed changes

@sean-perkins sean-perkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@averyrousseau
averyrousseau merged commit 0afa14e into FW-4612 Sep 1, 2023
@averyrousseau
averyrousseau deleted the FW-4763 branch September 1, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sean-perkins sean-perkins sean-perkins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: angular @ionic/angular package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@averyrousseau @sean-perkins