refactor(many): convert dynamic type rem values to Sass functions - #28209
Merged
Conversation
brandyscarney
commented
Sep 21, 2023
|
|
||
| /// @prop - Font size of the list header | ||
| $list-header-ios-font-size: min(1.375rem, 56px) !default; | ||
| $list-header-ios-font-size: dynamic-font-max(22px, 2.55) !default; |
Member
Author
There was a problem hiding this comment.
22px * 2.55 = 56.1px which may be causing the weird screenshot diffs from the max being 56px previously
| /// The minimum and maximum font sizes for a toolbar button are | ||
| /// 100% and 135%, respectively, of their default font size | ||
| $toolbar-ios-button-font-size: clamp(17px, 1.0625rem, 21px) !default; | ||
| $toolbar-ios-button-font-size: dynamic-font-clamp(1, 17px, 1.24) !default; |
Member
Author
There was a problem hiding this comment.
17px * 1.24 = 21.08px which may be causing the weird screenshot diffs from the max being 21px previously
brandyscarney
force-pushed
the
bc-refactor-rem-units
branch
from
September 27, 2023 21:11
73a3e0f to
b311f27
Compare
brandyscarney
force-pushed
the
bc-refactor-rem-units
branch
from
September 27, 2023 21:11
b311f27 to
3f3c129
Compare
brandyscarney
marked this pull request as ready for review
September 28, 2023 14:39
brandyscarney
requested review from
averyrousseau,
liamdebeasi and
sean-perkins
as code owners
September 28, 2023 14:39
liamdebeasi
approved these changes
Sep 28, 2023
averyrousseau
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts some of the
remunits for dynamic font scaling to use thedynamic-fontfunctions that didn't exist when these were implemented.There were a few other components that still use the old functions
clamp,min,max(chip, datetime) but I did not implement those so I don't know the purpose of leaving them. I can migrate if desired.