Skip to content

fix(radio): radio mark icon scales with font - #28237

Merged
liamdebeasi merged 3 commits into
FW-4146from
radio-font-scale
Sep 27, 2023
Merged

fix(radio): radio mark icon scales with font#28237
liamdebeasi merged 3 commits into
FW-4146from
radio-font-scale

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

Issue number: N/A


What is the current behavior?

Maria noted that the radio mark does not scale but should according to the iOS guidelines:

Simulator Screenshot - iPhone 14 Pro - 2023-09-26 at 11 44 44

What is the new behavior?

  • Radio mark scales with font

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: core @ionic/core package label Sep 26, 2023
@liamdebeasi
liamdebeasi marked this pull request as ready for review September 27, 2023 13:44
@liamdebeasi
liamdebeasi requested a review from a team September 27, 2023 13:44
@thetaPC thetaPC mentioned this pull request Sep 27, 2023
2 tasks

@thetaPC thetaPC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi
liamdebeasi merged commit f932cf3 into FW-4146 Sep 27, 2023
@liamdebeasi
liamdebeasi deleted the radio-font-scale branch September 27, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants