Skip to content

fix(radio): add icon scaling #28240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thetaPC wants to merge 2 commits into from
Closed

fix(radio): add icon scaling #28240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c574d9
fix(radio): add icon scaling
thetaPC Sep 26, 2023
154a248
test(radio): remove only
thetaPC Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/components/radio/radio.ios.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ $radio-ios-color-on: current-color(base) !default;
$radio-ios-background-color-focused: ion-color(primary, tint) !default;

/// @prop - Width of the radio icon
$radio-ios-icon-width: 15px !default;
$radio-ios-icon-width: dynamic-font(15px) !default;

/// @prop - Height of the radio icon
$radio-ios-icon-height: 24px !default;
$radio-ios-icon-height: dynamic-font(24px) !default;

/// @prop - Border width of the radio icon
$radio-ios-icon-border-width: 2px !default;
Expand Down
4 changes: 2 additions & 2 deletions core/src/components/radio/radio.md.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ $radio-md-background-color-focused: ion-color(primary, tint) !default;
$radio-md-color-off: rgb($text-color-rgb, 0.60) !default;

/// @prop - Width of the radio icon
$radio-md-icon-width: 20px !default;
$radio-md-icon-width: dynamic-font-max(20px, 2.5) !default;

/// @prop - Height of the radio icon
$radio-md-icon-height: 20px !default;
$radio-md-icon-height: dynamic-font-max(20px, 2.5) !default;

/// @prop - Border width of the radio icon
$radio-md-icon-border-width: 2px !default;
Expand Down
25 changes: 25 additions & 0 deletions core/src/components/radio/test/a11y/radio.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,28 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
});
});
});

configs({ directions: ['ltr'] }).forEach(({ title, config, screenshot }) => {
test.describe(title('radio: a11y'), () => {
test.describe(title('radio: font scaling'), () => {
test('should scale text on larger font sizes', async ({ page }) => {
await page.setContent(
`
<style>
html {
font-size: 310%;
}
</style>
<ion-radio-group value="strawberries">
<ion-radio value="strawberries">Strawberries</ion-radio><br />
</ion-radio-group>
`,
config
);

const radio = page.locator('ion-radio');
await expect(radio).toHaveScreenshot(screenshot('radio-scale'));
});
});
});
});