fix(animation): play method resolves when animation is stopped - #28264
Merged
Conversation
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
October 2, 2023 16:55
liamdebeasi
requested review from
a team and
brandyscarney
and removed request for
a team
October 2, 2023 16:55
brandyscarney
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
When trying to fix #20092, I discovered that
ionic-framework/core/src/components/menu/menu.tsx
Line 483 in ac2c8e6
ionic-framework/core/src/components/menu/menu.tsx
Line 699 in ac2c8e6
menu.disabledis set totruemid-animation.In order to fix the menu bug, I need this promise to resolve when the animation is stopped.
What is the new behavior?
playmethod now correctly resolves when the animation is cancelled.Does this introduce a breaking change?
Other information
The
playmethod resolves when a particular run of the animation is finished. Thestopmethod ensures that this run never finishes which is why I've chosen to haveplayresolve. Note thatonFinishcallbacks should not be fired because the animation run did not complete.