feat(angular, react, vue, core): export openURL utility - #28295
Merged
liamdebeasi merged 2 commits intoOct 9, 2023
Conversation
fpladano
requested review from
averyrousseau,
liamdebeasi,
sean-perkins and
thetaPC
as code owners
October 5, 2023 23:02
github-actions
Bot
added
package: core
sean-perkins
suggested changes
Oct 6, 2023
| export { isPlatform, Platforms, PlatformConfig, getPlatforms } from './utils/platform'; | ||
| export { IonicSafeString } from './utils/sanitization'; | ||
| export { IonicConfig, getMode, setupConfig } from './utils/config'; | ||
| export { openURL } from "./utils/theme"; |
Contributor
There was a problem hiding this comment.
The code formatting here will fail our prettier diff check due to the use of double quotes instead of single quotes.
In the packages/core project, you can run npm run prettier -- --write and commit the diff.
Contributor
Author
There was a problem hiding this comment.
Thanks! I've pushed the changes
sean-perkins
changed the title
Update openURL import to use single quotes
liamdebeasi
changed the title
liamdebeasi
changed the title
sean-perkins
approved these changes
Oct 9, 2023
sean-perkins
left a comment
sean-perkins
left a comment
Contributor
There was a problem hiding this comment.
Perfect, thank you for your help!
3 tasks
Contributor
|
Merged. Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27911
What is the current behavior?
The
openURLutility is not available to developers.What is the new behavior?
openURLutilities from@ionic/core,@ionic/angular,@ionic/reactand@ionic/vue.Does this introduce a breaking change?
Other information