chore: use ionicons 7.2 - #28318
Merged
Merged
Conversation
liamdebeasi
force-pushed
the
update-ionicons-75
branch
from
October 10, 2023 16:35
03acbdd to
7cfa476
Compare
liamdebeasi
force-pushed
the
update-ionicons-75
branch
from
October 10, 2023 17:08
035bfa6 to
519a5a4
Compare
liamdebeasi
marked this pull request as ready for review
October 10, 2023 17:15
This reverts commit e68412d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The Dynamic Font Scaling branch was using an outdated version of Ionicons which did not support Dynamic Font Scaling. There were no visual diffs because we typically override the size of the icon internally, but still good to be on the latest version.
What is the new behavior?
Does this introduce a breaking change?
Other information