fix(angular): NavController works with nested outlets - #28421
Merged
Conversation
liamdebeasi
marked this pull request as ready for review
October 26, 2023 14:23
sean-perkins
approved these changes
Oct 26, 2023
thetaPC
approved these changes
Oct 26, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28417
What is the current behavior?
The common
IonRouterOutletwas trying to inject another commonIonRouterOutletintoparentOutlet:ionic-framework/packages/angular/common/src/directives/navigation/router-outlet.ts
Line 119 in dc94ae0
null.This is a problem if developers are using the module
IonRouterOutletsince parent router outlets will not be currently injected because Angular is trying to use the commonIonRouterOutletnot the moduleIonRouterOutlet: https://github.com/ionic-team/ionic-framework/blob/main/packages/angular/src/directives/navigation/ion-router-outlet.ts. The same goes for the standaloneIonRouterOutlet.This resulted in things such as
NavController.popnot working in nested outlets because the parentOutlet was not defined.What is the new behavior?
IonRouterOutletnow injects the correct router outlet instance forparentOutletDoes this introduce a breaking change?
Other information
Dev build:
7.5.3-dev.11698328998.1a79f815