Skip to content

fix(inputs): remove invalid legacy warnings in input, textarea, and select #28484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandyscarney merged 1 commit into from
Nov 7, 2023
Merged

fix(inputs): remove invalid legacy warnings in input, textarea, and select #28484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions core/src/utils/forms/form-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ export type LegacyFormController = {
};

const hasLabelSlot = (controlEl: HTMLElement) => {
const root = controlEl.shadowRoot;
if (root === null) {
return false;
}

/**
* Components that have a named label slot
* also have other slots, so we need to query for
Expand All @@ -74,5 +69,5 @@ const hasLabelSlot = (controlEl: HTMLElement) => {
return false;
};

const NAMED_LABEL_SLOT_COMPONENTS = ['ION-RANGE'];
const NAMED_LABEL_SLOT_COMPONENTS = ['ION-INPUT', 'ION-TEXTAREA', 'ION-SELECT', 'ION-RANGE'];
const UNNAMED_LABEL_SLOT_COMPONENTS = ['ION-TOGGLE', 'ION-CHECKBOX', 'ION-RADIO'];