chore(jest): toHaveShadowPart custom matcher - #28610
Merged
Merged
Conversation
Contributor
Author
|
Let me know if you think this approach is worth pursuing/merging. I think custom matchers could help reduce some of the test boilerplate required for these common scenarios. |
sean-perkins
marked this pull request as ready for review
November 30, 2023 04:03
sean-perkins
requested review from
brandyscarney and
liamdebeasi
and removed request for
a team and
brandyscarney
November 30, 2023 04:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
What is the new behavior?
expect(el).toHaveShadowPart('partName')Does this introduce a breaking change?
Other information