fix(md): item border has improved contrast in dark mode - #29398
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
April 25, 2024 14:39
liamdebeasi
changed the title
sean-perkins
approved these changes
Apr 26, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29386
What is the current behavior?
The item border does not have sufficient contrast in dark mode making the border almost invisible.
What is the new behavior?
--ion-border-colorin the MD dark palette. Instead, we're using the theme default.Does this introduce a breaking change?
Other information
The earliest reference to the offending line Brandy and I could find was here.