fix(react): add onPointerDown, onTouchEnd, add onTouchMove - #29736
Merged
Conversation
missing HTML types closes ionic-team#29174
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
changed the title
sean-perkins
changed the title
sean-perkins
approved these changes
Aug 1, 2024
sean-perkins
left a comment
sean-perkins
left a comment
Contributor
There was a problem hiding this comment.
Verified the changes locally, thanks for your contribution!
I'll add a core team member to review so that it can be merged. My review is the equivalent of moral support when it comes to merging 😄
sean-perkins
requested review from
brandyscarney and
thetaPC
and removed request for
gnbm
August 1, 2024 18:17
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 2, 2024
3 tasks
This was referenced Sep 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29174
What is the current behavior?
React throws tab errors with
IonTabButtonwhen binding toonPointerDown,onTouchEndandonTouchMoveWhat is the new behavior?
onPointerDown,onTouchEndandonTouchMovetoIonTaButtonDoes this introduce a breaking change?