fix(modal): change default visibility to original footer when expandToScroll is false

[kumibrr]

Issue number: resolves #30315

---

What is the current behavior?

When expandToScroll = false, the original footer is swapped by a cloned one to avoid animation issues.
But if the original footer has some eventListeners, they won't work on the cloned footer.

What is the new behavior?

Footer visibility is the original by default, and the visibility will swap to the cloned one when the animation starts, and will be swapped back to the original when the animation ends

Does this introduce a breaking change?

• Yes
• No

Other information

Before	After
Screen.Recording.2025-03-26.at.19.13.47.mov	Screen.Recording.2025-03-26.at.19.14.32.mov

EDIT: The button in the videos "jump" from left to right, this is caused by another issue I discovered yesterday (stylesheets not being applied), but it's quite tricky to solve. I've opened an issue for that #30312

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ionic-framework	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 4, 2025 6:21pm

[thetaPC]

Thank you for submitting the PR! However, we require issues to be submitted first and then tied to the PR for us to proceed with reviewing.

[kumibrr]

Thank you for submitting the PR! However, we require issues to be submitted first and then tied to the PR for us to proceed with reviewing.

Done!

[thetaPC]

Let's also add a test to prevent a regression under modal/test/sheet/modal.e2e.ts. I recommend using this test as a base. Place the new test under the rendering group.

[kumibrr]

@thetaPC Done!

[thetaPC]

Almost, just some minor requests!

[thetaPC]

LGTM, requesting more approvals

[brandyscarney]

Thank you for the PR and your continued work on this, we really appreciate it. 🙂

I noticed an issue on md mode that was introduced with this fix. The footer is not visible and then becomes visible after the modal is fully presented. Here are comparison videos of the modal on main vs this PR:

main	PR branch
main-sheet.mp4	PR-sheet.mp4

This can be reproduced on Chrome, Firefox and Safari without emulating a device. It does not happen in ios mode.

[kumibrr]

@brandyscarney Thank you for pointing that issue. I'll work on it later this weekend.

[thetaPC]

@kumibrr Let's place this PR on hold. Due to the increase number of issues submitted due to the ion-footer, we are going go back to the drawing board on how we can render the original footer instead of making a copy.