fix(config): allow LogLevel to work with isolatedModules and update all warns and errors to respect logLevel - #30350
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
Bot
added
package: core
github-actions
Bot
removed
package: angular
Aravind-blip
reviewed
Mar 2, 2026
Aravind-blip
left a comment
Aravind-blip
left a comment
There was a problem hiding this comment.
This change correctly removes const from the enum to resolve the isolatedModules error and consistently replaces direct console logs with printIonWarning and printIonError to ensure logLevel is respected. Updates are applied systematically across components and corresponding tests are adjusted to match the new log format. The implementation is cohesive and aligned with the stated goal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
LogLevelthrows errorError: Cannot access ambient const enums when 'isolatedModules' is enabledlogLevelconfigWhat is the new behavior?
constfrom theenumto work withisolatedModulesconsole.warns toprintIonWarningconsole.errors toprintIonErrorDoes this introduce a breaking change?
Other information
Dev build:
8.5.5-dev.11744729748.174bf7e0