Skip to content

Fixes text selection in UITextInput when cursor is out of the box - #587

Merged
ivansafrin merged 1 commit into
ivansafrin:masterfrom
fodinabor:UITextInputSelectionFix
Dec 28, 2014
Merged

Fixes text selection in UITextInput when cursor is out of the box #587
ivansafrin merged 1 commit into
ivansafrin:masterfrom
fodinabor:UITextInputSelectionFix

Conversation

@fodinabor

Copy link
Copy Markdown
Contributor

Since fooflare removed their fork, I'm just kind of reopening: #550

@ivansafrin

Copy link
Copy Markdown
Owner

Ach! I gotta merge these things faster :(

@fodinabor

Copy link
Copy Markdown
Contributor Author

Would it be helpful if "we" (the community) would say whether it works for us / is helpful and such things?

@fodinabor

Copy link
Copy Markdown
Contributor Author

Well this isn't fixed completely.. I think the problem I have is mainly windows specific:
When your mouse gets out of the window while dragging, the mouseButton state wouldn't be changed - I think I'm gonna have to switch the mouseButton sate from being set by a windows event to check in the core update funtion - I will commit the core change to the FixPaused branch (for avoiding merge errors..)

@fodinabor

Copy link
Copy Markdown
Contributor Author

Is fixed on windows (I don't know whether this issue appears on other OS, too) in #519

@fooflare

Copy link
Copy Markdown
Contributor

I will check it in Linux (OS I made this patch). It is true, I didn't consider that case, well seen :)

@fooflare

Copy link
Copy Markdown
Contributor

I have checked the out of window issue in Linux and it doesn't appear, it works as it should just with this change. In OSX, I can't confirm, sorry.

ivansafrin added a commit that referenced this pull request Dec 28, 2014
Fixes text selection in UITextInput when cursor is out of the box
@ivansafrin
ivansafrin merged commit 3d83685 into ivansafrin:master Dec 28, 2014
@fodinabor
fodinabor deleted the UITextInputSelectionFix branch December 31, 2014 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants