Handle fatal errors correctly#140
Merged
Merged
Conversation
jeroenrinzema
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was special behaviour for the
InvalidPassworderror type, but there are many more possibilities for fatal errors. Query handlers might return them for a variety of reasons. All of such errors are expected to close the connection, that's what FATAL (or PANIC) means. This starts handling such non-recoverable errors correctly, by closing the connection when they occur.It also marks
NewErrUnkownStatementas ERROR, instead of FATAL, because it is not a fatal error (and now it creates different behaviour).