Fix StackTrace printing when multiple exceptions occur (#1238)#1359
Conversation
|
Who calls printStackTrace directly and why? |
|
@marcphilipp apparently, we do: https://github.com/junit-team/junit4/search?utf8=%E2%9C%93&q=printStackTrace The only call I see that could take in a |
|
Thanks for the pointer! @kcooney Do you foresee this causing any issues? |
|
@marcphilipp if users store these logs, then the log files could obviously get longer. The output might be hard to read, but if there are multiple failures then we should print something about each of them. We might want to revisit trimming the stack traces in the future. Each of these traces would likely contain duplicate frames that include the guts of JUnit |
|
I am in favor of merging this change. @junit-team/junit-committers What do you guys think? |
|
@jacobrh91 could you please update the release notes? |
I fixed the way MultipleFailureException prints the stacktraces. Now, when multiple exceptions are found, the stacktrace for each exception is printed