replaced unmaintained jwt library for maintained fork - #1920
Closed
cezary-butler wants to merge 1 commit into
Closed
replaced unmaintained jwt library for maintained fork#1920cezary-butler wants to merge 1 commit into
cezary-butler wants to merge 1 commit into
Conversation
…wn vulnerability)
Contributor
|
Please see #1916 (comment) Note: Echo is not using code that verifies This is where token is created/parsed: Lines 253 to 271 in 58366f9 Most problematic is that drijalva is unmaintained. This will be addressed in future. |
Author
|
If I understand correctly this is not how this change will be processed in the future. @aldas thanks for detailed explanation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The github.com/dgrijalva/jwt-go library has a known vulnerability: GHSA-w73w-5m7g-f7qc. Unfortunately it is also unmaintained and has no stable version with fix for the issue.
Since the is unmaintained and there is no stable version with fix for the mentioned issue, we have to migrate to the community maintained: github.com/golang-jwt/jwt.
Since middleware puts struct from the library into the context and the structures do not provide methods which could be used in interfaces, echo is tightly coupled to the jwt library and changing the library is a breaking change.
This could be solved by defining alias type and defining access methods on it. Introducing that change would still break compatibility, but it would allow to implement changes later without breaking compatibility.