Use camel case log name in DataBlobKey - #1649
Conversation
🦋 Changeset detectedLatest commit: 413fcb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| uint32 request_id = 1 [(logger.name) = "requestID"]; | ||
| // Identity of the participant who owns the blob. | ||
| string participant_identity = 2; | ||
| string participant_identity = 2 [(logger.name) = "participantIdentity"]; |
There was a problem hiding this comment.
don't think we need for this.
There was a schema_id, that needs to be schemaID logger name.
There was a problem hiding this comment.
Makes sense, added in 16b5572. Is the standard every field that gets logged in a request/response message should be camal case? Happy to revert for participant_identity if it's not necessary.
| uint32 request_id = 1 [(logger.name) = "requestID"]; | ||
| // Identity of the participant who owns the blob. | ||
| string participant_identity = 2; | ||
| string participant_identity = 2 [(logger.name) = "participantIdentity"]; |
There was a problem hiding this comment.
This is not needed. We do not have this anywhere else. It is just that we want ID upper case that needs the logger name option.
This reverts commit eb29d48.
ladvoc
changed the title
GetDataBlobRequestDataBlobKey
2 participants
Follow-up to #1553